Fix false positive update alert when local version is newer - #910
Closed
henriquegeremia wants to merge 2 commits into
Closed
Fix false positive update alert when local version is newer#910henriquegeremia wants to merge 2 commits into
henriquegeremia wants to merge 2 commits into
Conversation
Collaborator
|
Nice catch! |
umireon
reviewed
Jun 27, 2026
umireon
left a comment
Collaborator
There was a problem hiding this comment.
You can use regex. This part is run only once and regex is preferred to stringstream.
Author
|
Done! I've updated the implementation to use std::regex instead of std::stringstream. Thanks for the feedback! |
umireon
requested changes
Jun 28, 2026
Collaborator
|
You are required to check the Pull Request checklist I've added. Do not remove template. |
henriquegeremia
force-pushed
the
fix/update-checker-logic
branch
from
June 28, 2026 18:12
50d4a28 to
2f1267a
Compare
henriquegeremia
marked this pull request as ready for review
June 28, 2026 18:12
Author
|
Done! I've updated the regex to match the exact pattern you suggested, restored the PR checklist template, and marked the PR as ready for review. |
umireon
approved these changes
Jul 6, 2026
Collaborator
|
@henriquegeremia Thanks for contribution! Finally, please sign your commits and add DCO! See https://github.com/royshil/obs-backgroundremoval/blob/main/CONTRIBUTING.md#4-developer-certificate-of-origin-dco-and-commit-signing |
Collaborator
|
Stalled. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the plugin incorrectly alerts the user that an update is available when the locally installed version is actually newer than the latest version fetched from the GitHub API.
Currently, users running a newer local version (e.g.,
1.4.0) are prompted with🚀 Update available! (1.3.7)because the update checking logic inupdate-checker.cpponly checks for strict equality (info.version == PLUGIN_VERSION). If the versions do not match, it assumes a new update is available.Solution
is_newer_versionthat splits both the remote and local version strings by.and compares the integer components sequentially.check_updateto only setlatestVersionForUpdateif the fetched remote version is strictly newer than the currently installedPLUGIN_VERSION.Pull Request Checklist
Please read our latest CONTRIBUTING.md.