Fix broken star history chart - #948
Closed
Dessalines39394 wants to merge 1 commit into
Closed
Conversation
The star history chart in the README is currently broken because the original service is no longer able to provide the data reliably. Point the chart at the replacement service so the chart renders correctly again. Signed-off-by: Kaito Udagawa <umireon@kaito.tokyo>
Owner
|
@umireon what do you think? it's fine I suppose |
Collaborator
|
I suppose we should remove the direct link to the image because I concern some privacy risks for users. Instead, we can add a static snapshot for star history. Is this fine? |
Author
|
FYI Github proxies and caches all images, so that users will never query third-parties directly |
Collaborator
This statement is not like what we can accept. Since it originates from third-party, we cannot say that this is completely safe for users. |
Collaborator
|
We have decided to replace star history with a static image included in our repo. Thanks for opening PR, but we will go to the other way. Closing it with gratefulness ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The star history chart in the README has stopped working, which leaves the project page without a usable overview of its growth. This change switches the chart to a working service so it renders correctly again.
This is a documentation-only change and has no effect on the plugin itself.