Skip to content

Single-argument constructor overload #20

Description

@bsideup

Hi!

If I have a service named MyService , the current implementation generates a constructor (MyServiceServer) with 3 parameters:

  1. MyService
  2. Optional<MeterRegistry>
  3. Optional<Tracer>

The problem is that if you exclude opentracing & micrometer from the classpath, new MyServiceServer(myService, Optional.empty(), Optional.empty()) fails at runtime because it refers to the missing classes. There is a workaround for it:

new MyServiceServer(myService, (Optional) Optional.empty(), (Optional) Optional.empty());

But it would be nice if the generator will create an additional constructor, without optionals and @Inject at all:

new MyServiceServer(myService);

and delegate to this(service, Optional.empty(), Optional.empty());

Not everyone is using opentracing and/or micrometer and it will help to not have them on classpath

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions