Repository navigation
Conversation
Nothing in lib/, test/, R/, or assets/ ever read req.session_state, and because the lazy Session.content getter was never touched, no session_state cookie was ever actually emitted. It also broke the WebSocket upgrade path by calling the middleware with res=null, which made client-sessions throw and swallow the error. Dropping it outright rather than fixing the upgrade-path bug. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client-sessionsmiddleware fromlib/server-init.js, along with its dependency (package.json,npm-shrinkwrap.json) and license entry (NOTICE.md)lib/,test/,R/, orassets/ever readreq.session_state, and because the lazySession.contentgetter was never touched, nosession_statecookie was ever actually emittedres=null, which madeclient-sessionsthrow internally and silently swallow the error — upgrades worked, but one tick late. Removed outright rather than fixed, since it was vestigialmemory-bank/proxyLayer.md,memory-bank/requestLifecycle.md, andmemory-bank/techContext.mdto reflect the removalTest plan
npm run build && npm test/r-hello/and a SockJS/WebSocket-backed app still work end to end (nosession_statecookie expected before or after)🤖 Generated with Claude Code