Repository navigation
Conversation
…sers can changes the settings through api
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 6.81% 6.93% +0.11%
+ Complexity 601 589 -12
==========================================
Files 20 20
Lines 3036 2987 -49
==========================================
Hits 207 207
+ Misses 2829 2780 -49
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small admin fixes:
oneaccess_manage_settings(Network Admin / Brand Admin) instead ofmanage_options.POST /site-typestill acceptsmanage_optionswhile the site type is unset, so onboarding keeps working.Testing
On a local governing site and brand site:
mainthey got 200, including/secret-key). A plain admin can still complete onboarding.Notes
main, brand sites crash with a fatal error inProfile_Request, which is fixed by a4da9cd in fix: cross-site user management and auth hardening #195. Apply that commit locally to test the brand side.Checklist