Skip to content

test(phpunit): covered qa sheet testcases - #371

Merged
justlevine merged 2 commits into
mainfrom
test/phpunit-coverage
Oct 31, 2026
Merged

justlevine merged 2 commits into
mainfrom
test/phpunit-coverage

Conversation

@Kallyan01

@Kallyan01 Kallyan01 commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

What

Adds PHPUnit integration coverage for QA cases TC-3, TC-31, TC-43, TC-44, TC-72, TC-81, and TC-83 across four test files.

Why

Improves regression coverage for governing-site uninstall, site-specific admin menus, brand connection failures, and search behavior.

Related Issue(s):

How

  • Uninstall: Checks brand disconnect requests and per-site keys, the Algolia index request path, local cleanup, pending-job removal, and retention of completed jobs and their logs.
  • Admin menus: Checks the submenu titles shown for governing and brand sites.
  • Brand connection errors: Covers invalid API keys, DNS failures, timeouts, and missing OneSearch routes, asserting response messages, status codes, unchanged empty configuration, and the five-second timeout setting.
  • Search: Checks site filters and expected results, preservation of special characters in Algolia queries, escaped search-term output through the WordPress helper, and admin result pass-through without Algolia calls.

AI Disclosure

AI assisted with a review of the test coverage and PR description.

Testing Instructions

Screenshots

Additional Info

Checklist

  • I have read the Contribution Guidelines.
  • I have read the Development Guidelines.
  • I have added necessary tests to cover my changes.
  • I have updated the project documentation as needed.
  • My code has detailed inline documentation.
  • My code is tested to the best of my abilities.
  • My code passes all lints, tests, and checks.
Open WordPress Playground Preview

@Kallyan01
Kallyan01 requested a review from justlevine October 30, 2026 16:30
@Kallyan01
Kallyan01 marked this pull request as ready for review October 30, 2026 16:30
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (ccf6d2a) to head (aacaca2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #371      +/-   ##
============================================
+ Coverage     88.83%   90.07%   +1.24%     
  Complexity      848      848              
============================================
  Files            49       36      -13     
  Lines          3279     2671     -608     
  Branches        180        0     -180     
============================================
- Hits           2913     2406     -507     
+ Misses          310      265      -45     
+ Partials         56        0      -56     
Flag Coverage Δ
unit 90.07% <ø> (+0.41%) ⬆️
vitest ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@justlevine justlevine left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No notes. Thanks @Kallyan01 🚀

@justlevine
justlevine merged commit 5af4ee0 into main Oct 31, 2026
17 checks passed
@justlevine
justlevine deleted the test/phpunit-coverage branch October 31, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants