Skip to content

fix: add menu icon styles for full opacity in admin screens - #372

Merged
justlevine merged 1 commit into
mainfrom
fix/onesearch-icon
Nov 2, 2026
Merged

justlevine merged 1 commit into
mainfrom
fix/onesearch-icon

Conversation

@Kallyan01

@Kallyan01 Kallyan01 commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

What

Minor icon opacity fix.

Why

image

Related Issue(s):

How

AI Disclosure

Testing Instructions

Screenshots

Additional Info

Checklist

  • I have read the Contribution Guidelines.
  • I have read the Development Guidelines.
  • I have added necessary tests to cover my changes.
  • I have updated the project documentation as needed.
  • My code has detailed inline documentation.
  • My code is tested to the best of my abilities.
  • My code passes all lints, tests, and checks.
Open WordPress Playground Preview

Copilot AI balanced review requested due to automatic review settings November 2, 2026 16:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change making the OneSearch admin menu icon fully opaque.

No open issues 🎉

What changed in this PR

This PR makes the OneSearch menu icon fully opaque across WordPress admin screens.

Changes:

  • Registers a callback on admin_enqueue_scripts.
  • Adds inline CSS to the wp-admin stylesheet, targeting only the OneSearch menu icon.
File Description
inc/​Modules/​Settings/​Admin.php Adds the hook and inline style that set the menu icon’s opacity to 1.

Review effort: Balanced

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.01%. Comparing base (5af4ee0) to head (b1e555b).

Files with missing lines Patch % Lines
inc/Modules/Settings/Admin.php 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #372      +/-   ##
============================================
- Coverage     90.07%   90.01%   -0.07%     
- Complexity      848      849       +1     
============================================
  Files            36       36              
  Lines          2671     2674       +3     
============================================
+ Hits           2406     2407       +1     
- Misses          265      267       +2     
Flag Coverage Δ
unit 90.01% <33.33%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
inc/Modules/Settings/Admin.php 87.30% <33.33%> (-2.70%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kallyan01
Kallyan01 requested a review from justlevine November 2, 2026 16:38
@justlevine
justlevine merged commit b3be2eb into main Nov 2, 2026
21 of 22 checks passed
@justlevine
justlevine deleted the fix/onesearch-icon branch November 2, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants