Repository navigation
fix: improve content chunking logic - #376
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Oversized fixed metadata can trigger excessive record allocation and exhaust indexing-worker memory, while empty posts whose records exactly fit the size limit are incorrectly rejected.
2 open issues
What changed in this PR
This PR updates Algolia record chunking to measure complete JSON-encoded records and retry with smaller content chunks when records exceed the size limit.
Changes:
- Centralizes chunk-record construction and encoded-size measurement.
- Rechecks record sizes after filters run and reduces chunk sizes on overflow.
- Adds integration tests for escaped markup, oversized metadata, and filter-driven rechunking.
| File | Description |
|---|---|
| tests/phpunit/Integration/Modules/Search/PostRecordTest.php | Adds encoded-size and filtered-record chunking tests. |
| inc/Modules/Search/Post_Record.php | Measures full encoded records and retries oversized chunks. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
justlevine
approved these changes
Nov 3, 2026
Collaborator
|
(cloned from #375 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What
Fixes the handling of chunk sizing to use the full json-encoded size for measurement. If the chunk is too big, it's rechunked by the loop.
Why
Related:
How
AI Disclosure
Testing Instructions
Screenshots
Additional Info
Co-authored-by: @justlevine
Checklist