Conversation
(called omnibar)
Owner
Author
|
Upstream declined change, but in the future a whole new API could come. That means, for now, we could only adjust this to copy the emoji to the clipboard, at least. (after we get |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
So the search now works and correctly falls back to copying the emoji, if it has the permission.
Owner
Author
|
TODO:
|
This comment has been minimized.
This comment has been minimized.
So we can now request permissions properly and ask the user.
Now only hides the active message in case of rejection.
And add TODO
Owner
Author
|
possibly depending on TinyWebEx/AutomaticSettings#10 |
Owner
Author
|
Ready to merge. Possibly only TODO:
|
Owner
Author
|
Note: If a solution for opening the popup or so is found, passing the search term to the popup should be quite easily possible: missive/emoji-mart#266 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(called omnibar)
Edit: Fixes #33
Blocked (?) by: