Remove unremap file when running cargo clean -p in new build-dir layout - #17356
Merged
weihanglo merged 2 commits intoAug 13, 2026
Merged
Conversation
rustbot
added
Command-clean
S-waiting-on-review
weihanglo
approved these changes
Aug 13, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
See #17354 (comment) for the motivating context.
In #17303 we started emitting unremap files to final artifacts.
This included logic for cleaning the unremap file when running
cargo clean -pbut the logic was not added in the.build_dir_new_layoutbranch in the cargo clean logic.This PR adds the logic to both branches.
How to test and review this PR?
Primarily using the existing tests
r? @weihanglo