Skip to content

[Clippy] Fix clippy issues in libgit2-sys crate #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weihanglo merged 3 commits into from
Jul 20, 2026
Merged

[Clippy] Fix clippy issues in libgit2-sys crate #1299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb0cfcf
[Clippy] Address `clippy::needless_borrows_for_generic_args` in libgi…
DanielEScherzer Jul 19, 2026
603dc11
[Clippy] Address `clippy::unnecessary_map_or` in libgit2-sys/build.rs
DanielEScherzer Jul 19, 2026
786d2d9
[Clippy] Address `clippy::legacy_numeric_constants` in libgit2-sys/li…
DanielEScherzer Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions libgit2-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
#![allow(clippy::needless_borrows_for_generic_args)]
#![allow(clippy::unnecessary_map_or)]

use std::env;
use std::fs;
use std::io;
Expand Down Expand Up @@ -96,7 +93,7 @@ fn main() {
// dependency graph activates `vendored` feature, there is no way to revert
// it back. This env var serves as a workaround for this purpose.
println!("cargo:rerun-if-env-changed=LIBGIT2_NO_VENDOR");
let forced_no_vendor = env::var_os("LIBGIT2_NO_VENDOR").map_or(false, |s| s != "0");
let forced_no_vendor = env::var_os("LIBGIT2_NO_VENDOR").is_some_and(|s| s != "0");

if forced_no_vendor {
if try_system_libgit2(unstable_sha256).is_err() {
Expand All @@ -123,7 +120,7 @@ The build is now aborting. To disable, unset the variable or use `LIBGIT2_NO_VEN

if !Path::new("libgit2/src").exists() {
let _ = Command::new("git")
.args(&["submodule", "update", "--init", "libgit2"])
.args(["submodule", "update", "--init", "libgit2"])
.status();
}

Expand Down
3 changes: 1 addition & 2 deletions libgit2-sys/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#![doc(html_root_url = "https://docs.rs/libgit2-sys/0.18")]
#![allow(non_camel_case_types, unused_extern_crates)]
#![allow(clippy::legacy_numeric_constants)]

// This is required to link libz when libssh2-sys is not included.
extern crate libz_sys as libz;
Expand Down Expand Up @@ -2085,7 +2084,7 @@ pub type git_commit_create_cb = Option<
) -> c_int,
>;

pub const GIT_REBASE_NO_OPERATION: usize = usize::max_value();
pub const GIT_REBASE_NO_OPERATION: usize = usize::MAX;

#[repr(C)]
pub struct git_rebase_options {
Expand Down