fix: add missing i18n keys for Static KMS, update SSE safety test regex - #181
Merged
Conversation
Other locale files were missing 5 new Static KMS keys added to en-US. SSE safety test regex for Create Key disabled prop needed to allow the new || staticKmsReadOnly suffix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #179. Two fixes missed in the initial PR:
i18n
13 locale files were missing the 5 new Static KMS UI keys added to en-US. This caused
all locale files provide the same keys as en-USandtranslated locale values preserve interpolation placeholderstests to fail.SSE safety test
The Create Key button disabled-prop regex in
sse-safety.test.jswas too strict — it required}immediately afterBoolean(keysError), but the code now appends|| staticKmsReadOnly. Removed the trailing\}from the regex pattern.Verification
pnpm test:run— 359 tests, 0 fail