fix: distinguish filtered object empty states - #184
Merged
Conversation
cxymds
marked this pull request as ready for review
July 26, 2026 10:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The object browser filtered only the objects already loaded in the client, but always reused the genuine empty-bucket copy when that filtered set was empty. This could incorrectly tell operators that a populated bucket had no objects.
User impact
Filtered searches no longer display the empty-bucket upload prompt. The UI now explains whether more objects remain unsearched or whether all loaded objects have been checked.
Closes #183
Validation
pnpm install --frozen-lockfilepnpm test:run(367/367 passed)pnpm tsc --noEmitpnpm lintgit diff origin/main --checkRepository-wide
pnpm prettier --check .still reports the existing formatting issue inapp/(dashboard)/sse/page.tsx; that file is unchanged by this PR.