fix(leader-election): validate lease duration conversions - #193
Merged
GatewayJ merged 1 commit intoJul 21, 2026
Merged
Conversation
GatewayJ
marked this pull request as ready for review
July 21, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Closes rustfs/backlog#1081
Summary of Changes
int32seconds field.The original issue also proposed clamping large positive durations. This change intentionally preserves every positive
int32duration because Kubernetes and client-go accept and honor those values. A unilateral cap could make a follower acquire before a legitimate holder's declared lease expires, creating two active leaders. Enforcing a smaller maximum would require a separately documented protocol constraint shared by all participants.Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](N/A: internal reliability fix with no user-facing workflow change)Impact
Verification
Additional Notes
Standard Kubernetes API validation rejects non-positive Lease durations, but the leader-election core also supports generic
Lockimplementations and must remain robust against malformed records. The Kubernetes adapter therefore preserves the wire value, while the core owns validity policy.Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.