docs: clarify Docker network host limitation on Windows (fixes #676)#859
Open
aayushprsingh wants to merge 1 commit into
Open
docs: clarify Docker network host limitation on Windows (fixes #676)#859aayushprsingh wants to merge 1 commit into
aayushprsingh wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Documentation update clarifying that Docker on Windows cannot be used for WiFi sensing because Docker Desktop does not support --network host for accessing native Windows WiFi adapters; users must build from source.
Changes:
- Replaces the Docker run example with an explanatory note about the Windows limitation.
- Directs Windows users to build from source for WiFi sensing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+316
to
+319
| # Docker | ||
| # Note: Docker Desktop on Windows does NOT support `--network host` to access native Windows WiFi adapters. | ||
| # Therefore, `--source wifi` will fail inside a Docker container on Windows. | ||
| # You MUST build from source to use Windows WiFi sensing. |
Comment on lines
+317
to
+319
| # Note: Docker Desktop on Windows does NOT support `--network host` to access native Windows WiFi adapters. | ||
| # Therefore, `--source wifi` will fail inside a Docker container on Windows. | ||
| # You MUST build from source to use Windows WiFi sensing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the user guide to clarify that Docker Desktop on Windows does not support --network host, which is required for --source wifi. It advises users to build from source instead when using Windows WiFi sensing, resolving issue #676.