[codex] harden Docker sensing-server auth defaults#865
Draft
essentiaMarco wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens the Docker sensing-server defaults so the container no longer starts a network-bound unauthenticated sensing surface by accident.
Changes:
sensing-serveron0.0.0.0,::, or[::]unlessRUVIEW_API_TOKENis non-empty.RUVIEW_ALLOW_UNAUTH_LAN=1opt-in.This addresses the Docker secure-default portion of #864. It intentionally does not redesign
/ws/sensingauth in this PR; that needs a separate browser-compatible WebSocket auth decision.Why
#443/#547 added opt-in bearer auth while preserving LAN-mode defaults. The remaining Docker-specific risk is that the image entrypoint starts
sensing-serveron0.0.0.0and Compose publishes ports whileRUVIEW_API_TOKENis empty by default. That makes sensing/pose REST data and the sensing WebSocket reachable to any client that can reach the Docker host.Failing closed for Docker keeps the maintainer-approved LAN mode available, but makes it an intentional deployment choice instead of an accidental default.
Validation
Runtime checks on the built image:
docker compose configreports the existing Composeversiondeprecation warning; no new config error was introduced.