Skip to content

fix(edge): gate multi-person count on presence — no phantom persons (#803, #496) #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markt-heximal wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

fix(edge): gate multi-person count on presence — no phantom persons (#803, #496) #892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions firmware/esp32-csi-node/main/edge_processing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,18 @@ static void update_multi_person_vitals(const uint8_t *iq_data, uint16_t n_sc,
{
if (s_top_k_count < 2) return;

/* Presence gate (issues #803, #496): only activate persons when presence is
* actually detected. Without this, the loop below unconditionally marks
* top_k/2 persons active every frame, so the reported n_persons is a fixed
* artifact of the subcarrier count (never 0) regardless of occupancy — an
* empty room still reports e.g. 4 "people". s_presence_detected is updated
* earlier in the same process_frame() pass. (This bounds the count to
* presence; true multi-person separation is a separate, larger problem.) */
if (!s_presence_detected) {
for (uint8_t p = 0; p < EDGE_MAX_PERSONS; p++) s_persons[p].active = false;
return;
}

/* Determine number of active persons based on available subcarriers. */
uint8_t n_persons = s_top_k_count / 2;
if (n_persons > EDGE_MAX_PERSONS) n_persons = EDGE_MAX_PERSONS;
Expand Down