You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pins Cello 0.2.3: ghcr.io/ryuzcorp/cello:0.2.3@sha256:460b7fadc8effa079e3b63f0e065fcdac97c50490a84d181e5f1a44feecb63f1 (attested, refs/tags/v0.2.3). sh scripts/check-pins.sh passes.
What changes for apps: since Cello 0.1.0, a streamed response (SSE, long downloads) went silent about 30 s after its handler answered (ryuzcorp/cello#103). Prod has run Cello 0.2.2 since today's wipe release, so it is affected. With 0.2.3, a stream lives while the client is connected, and a stream with no progress for 60 s ends: apps should send a keepalive at least once a minute.
Dogfood results follow in a comment.
Summary by CodeRabbit
Chores
Updated the container build configuration. No user-facing behavior changes are included.
This updates the pinned Cello image to 0.2.3 so streamed responses stay open while the client is connected, ending after 60 seconds without progress. No concrete merge-blocking risk was found. Apps that stream must send a keepalive at least once a minute to hold an idle stream open.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "Pin Cello 0.2.3" matches the single substantive change in the changeset. The Dockerfile now pins Cello to version 0.2.3 with a new digest, replacing 0.2.2. The title is short and specific, …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "Pin Cello 0.2.3" matches the single substantive change in the changeset. The Dockerfile now pins Cello to version 0.2.3 with a new digest, replacing 0.2.2. The title is short and specific, and a teammate scanning history would understand the main change. It does not mention the keepalive or 60-second stream timeout behavior, but the title does not need to cover every detail.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 20f31964-8718-43bf-98b1-a4a9cb6de8f2
Commits
Reviewing files that changed from the base of the PR and between ef1d9b6 and 585cb50.
Files selected for processing: 1
docker/Dockerfile
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Security review record. Independent reviewer SecPin023 (it wrote none of this) gives a verdict of OK, with no findings, for noite#394 and outer#155:
The digest sha256:460b…63f1 matches the v0.2.3 release body and its attestation (publish.yml at refs/tags/v0.2.3, commit 478328f8). The integrator also verified it live.
The image is consumed by digest only, through one pin.
The upstream delta is exactly cello#103, which was reviewed separately (SecStream, OK).
The 15 s SSE keepalives in both Noite feeds stay under the new 60 s no-progress deadline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins Cello 0.2.3:
ghcr.io/ryuzcorp/cello:0.2.3@sha256:460b7fadc8effa079e3b63f0e065fcdac97c50490a84d181e5f1a44feecb63f1(attested,refs/tags/v0.2.3).sh scripts/check-pins.shpasses.What changes for apps: since Cello 0.1.0, a streamed response (SSE, long downloads) went silent about 30 s after its handler answered (ryuzcorp/cello#103). Prod has run Cello 0.2.2 since today's wipe release, so it is affected. With 0.2.3, a stream lives while the client is connected, and a stream with no progress for 60 s ends: apps should send a keepalive at least once a minute.
Dogfood results follow in a comment.
Summary by CodeRabbit