Skip to content

Make std::jthread support conditional based on C++ 201911L#651

Draft
sbooth wants to merge 30 commits into
mainfrom
thread
Draft

Make std::jthread support conditional based on C++ 201911L#651
sbooth wants to merge 30 commits into
mainfrom
thread

Conversation

@sbooth

@sbooth sbooth commented Dec 1, 2025

Copy link
Copy Markdown
Owner

This is a draft PR to address uncertain availability of std::jthread in Apple clang.

@sbooth sbooth mentioned this pull request Dec 2, 2025
@farfromrefug

Copy link
Copy Markdown

@sbooth would love this ;)

@sbooth sbooth closed this Dec 21, 2025
@sbooth sbooth deleted the thread branch December 21, 2025 17:31
@farfromrefug

Copy link
Copy Markdown

@sbooth so you didnt go that route? how are you going to fix the build?

@sbooth

sbooth commented Dec 22, 2025

Copy link
Copy Markdown
Owner Author

I don't think that there is anything wrong with the build that needs to be fixed in main. It works correctly with Xcode 26 which I consider the baseline configuration.

@farfromrefug

Copy link
Copy Markdown

@sbooth but it wont build on intel mac using xcode 16. It is just one version below :( Forcing people to use xcode 26 is pretty tough. Not even sure i can install xcode 26 on intel

@sbooth

sbooth commented Dec 22, 2025

Copy link
Copy Markdown
Owner Author

I'm sure whether Xcode 26 is a tough requirement could be debated either way, but Xcode 26 does work on Intel Macs. I have an older Intel model and I'm using Xcode 26 with no issues. The only restriction I know of is that the visionOS SDK requires an ARM processor.

@farfromrefug

Copy link
Copy Markdown

@sbooth still pretty sad to see you force people to use xcode 26. Never seen a library do that kind of "requirement".
Will have to fork and manage it in my fork.
Thanks for the work you ve done

@sbooth sbooth restored the thread branch December 23, 2025 00:26
@sbooth

sbooth commented Dec 23, 2025

Copy link
Copy Markdown
Owner Author

I'll reopen this PR for further consideration.

@sbooth sbooth reopened this Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants