Skip to content

Add -audioPlayer:didSeek:toFrame: delegate method#891

Merged
sbooth merged 9 commits into
mainfrom
didseek
Jun 9, 2026
Merged

Add -audioPlayer:didSeek:toFrame: delegate method#891
sbooth merged 9 commits into
mainfrom
didseek

Conversation

@sbooth

@sbooth sbooth commented Mar 16, 2026

Copy link
Copy Markdown
Owner

No description provided.

@sbooth sbooth changed the title Add did seek delegate method Add -audioPlayer:didSeek:toFrame: delegate method Mar 16, 2026
@sbooth sbooth marked this pull request as ready for review June 9, 2026 15:24
Copilot AI review requested due to automatic review settings June 9, 2026 15:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new SFBAudioPlayerDelegate callback to notify clients when a user-initiated seek has completed, including the decoder instance and the resulting frame position.

Changes:

  • Introduces a new decoding event type (DecodingEventCommand::seek) and emits it after a successful seek.
  • Adds decoding-event handling to invoke the new delegate selector -audioPlayer:didSeek:toFrame:.
  • Extends the public SFBAudioPlayerDelegate protocol with the new optional method and updates delegate-notification documentation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
Sources/CSFBAudioEngine/Player/AudioPlayer.mm Emits and processes a new seek decoding event, dispatching the new delegate callback with the resulting frame.
Sources/CSFBAudioEngine/Player/AudioPlayer.h Adds the seek decoding event command and declares processDecoderSeekEvent().
Sources/CSFBAudioEngine/include/SFBAudioEngine/SFBAudioPlayer.h Adds the public optional delegate method -audioPlayer:didSeek:toFrame: and updates the delegate-notification list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sbooth sbooth merged commit 4dcdaa2 into main Jun 9, 2026
3 checks passed
@sbooth sbooth deleted the didseek branch June 9, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants