Conversation
-audioPlayer:didSeek:toFrame: delegate method
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new SFBAudioPlayerDelegate callback to notify clients when a user-initiated seek has completed, including the decoder instance and the resulting frame position.
Changes:
- Introduces a new decoding event type (
DecodingEventCommand::seek) and emits it after a successful seek. - Adds decoding-event handling to invoke the new delegate selector
-audioPlayer:didSeek:toFrame:. - Extends the public
SFBAudioPlayerDelegateprotocol with the new optional method and updates delegate-notification documentation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/CSFBAudioEngine/Player/AudioPlayer.mm | Emits and processes a new seek decoding event, dispatching the new delegate callback with the resulting frame. |
| Sources/CSFBAudioEngine/Player/AudioPlayer.h | Adds the seek decoding event command and declares processDecoderSeekEvent(). |
| Sources/CSFBAudioEngine/include/SFBAudioEngine/SFBAudioPlayer.h | Adds the public optional delegate method -audioPlayer:didSeek:toFrame: and updates the delegate-notification list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.