Skip to content

feat(Button): add accessible labeling and tooltip relation props - #6861

Merged
jsulpis merged 6 commits into
mainfrom
button-fix
Sep 4, 2026
Merged

feat(Button): add accessible labeling and tooltip relation props#6861
jsulpis merged 6 commits into
mainfrom
button-fix

Conversation

@jsulpis

@jsulpis jsulpis commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary

Add new tooltipLabel, tooltipDescription and accessibleLabel props to Button so accessible names and descriptions can be provided via a localizable hidden label and a tooltip with an explicit relation. Also remove the Tooltip opening delay in tests to make them faster and less flaky.

@jsulpis
jsulpis requested a review from lisalupi as a code owner September 2, 2026 15:13
@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 89671b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/ui/src/helpers/isTestEnvironment.ts Outdated
Comment thread packages/ui/src/components/Tooltip/useTooltip.ts
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.97%. Comparing base (ecc3e23) to head (89671b5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ges/ui/src/components/Dialog/components/Button.tsx 50.00% 1 Missing ⚠️
...s/ui/src/components/TextInput/ShowHidePassword.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6861      +/-   ##
==========================================
- Coverage   90.97%   90.97%   -0.01%     
==========================================
  Files         571      572       +1     
  Lines       10520    10526       +6     
  Branches     3791     3797       +6     
==========================================
+ Hits         9571     9576       +5     
- Misses        949      950       +1     
Files with missing lines Coverage Δ
packages/form/src/components/Submit/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/Alert/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/Button/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/CopyButton/index.tsx 94.44% <100.00%> (ø)
.../components/DateInput/components/CalendarDaily.tsx 100.00% <ø> (ø)
...omponents/DateInput/components/CalendarMonthly.tsx 100.00% <ø> (ø)
packages/ui/src/components/KeyValueInput/index.tsx 94.23% <100.00%> (ø)
...ckages/ui/src/components/List/ExpandButtonCell.tsx 55.55% <ø> (ø)
packages/ui/src/components/Modal/ModalContent.tsx 100.00% <ø> (ø)
...es/ui/src/components/Notification/Notification.tsx 100.00% <100.00%> (ø)
... and 21 more

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf3e5b...89671b5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsulpis
jsulpis requested a review from philibea September 3, 2026 13:07
@jsulpis
jsulpis merged commit 167aaa6 into main Sep 4, 2026
26 of 30 checks passed
@jsulpis
jsulpis deleted the button-fix branch September 4, 2026 11:43
@github-actions github-actions Bot mentioned this pull request Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants