Skip to content

feat(agent): add unit testing skill - #6868

Merged
philibea merged 3 commits into
mainfrom
unit-testing-skill
Sep 4, 2026
Merged

feat(agent): add unit testing skill#6868
philibea merged 3 commits into
mainfrom
unit-testing-skill

Conversation

@philibea

@philibea philibea commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

add unit testing skill

@changeset-bot

changeset-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d142326

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jsulpis jsulpis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add the instruction to gather all accessibility tests in a separate a11y.test.tsx file ?

Comment thread .agents/skills/unit-testing/SKILL.md Outdated
Comment thread .agents/skills/unit-testing/SKILL.md Outdated
@philibea

philibea commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

should we add the instruction to gather all accessibility tests in a separate a11y.test.tsx file

@jsulpis we should have a list of what we need to put there. Does a getbyRole is an a11y.test ?

@jsulpis

jsulpis commented Sep 3, 2026

Copy link
Copy Markdown
Member

should we add the instruction to gather all accessibility tests in a separate a11y.test.tsx file

@jsulpis we should have a list of what we need to put there. Does a getbyRole is an a11y.test ?

I don't understand the question. I would say the a11y.test.tsx file contains tests that check purely accessibility features like axe violations, keyboard support etc, while the regular tests use getByRole to check that the component renders and behaves correctly, so it can still check labels, descriptions etc but as a side effect. But the distinction is quite thin. wdyt ?

@philibea
philibea merged commit 157e615 into main Sep 4, 2026
3 checks passed
@philibea
philibea deleted the unit-testing-skill branch September 4, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants