Adopt timestamp-ordered microVersionId in CRR resync tool#395
Conversation
Hello maeldonn,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
1808039 to
1d860c7
Compare
| "@smithy/util-retry": "^4.0.7", | ||
| "JSONStream": "^1.3.5", | ||
| "arsenal": "git+https://github.com/scality/arsenal#8.2.36", | ||
| "arsenal": "git+https://github.com/scality/arsenal#improvement/ARSN-578/micro-version-id", |
There was a problem hiding this comment.
arsenal is pinned to a feature branch (improvement/ARSN-578/micro-version-id) instead of a release tag. Git-based deps must pin to a tag to ensure reproducible builds and avoid picking up unfinished or breaking changes from a moving branch head.
```suggestion
"arsenal": "git+https://github.com/scality/arsenal#",
There was a problem hiding this comment.
Yes, arsenal is not yet released.
Review by Claude Code |
| "@smithy/util-retry": "^4.0.7", | ||
| "JSONStream": "^1.3.5", | ||
| "arsenal": "git+https://github.com/scality/arsenal#8.2.36", | ||
| "arsenal": "git+https://github.com/scality/arsenal#improvement/ARSN-578/micro-version-id", |
There was a problem hiding this comment.
`arsenal` is pinned to a feature branch (improvement/ARSN-578/micro-version-id) instead of a release tag. Per project conventions, git-based deps must pin to a tag (like the previous #8.2.36). Branch references are unstable — the resolved commit can change on every install, and the branch may be rebased or deleted. This should be updated to a tagged release of arsenal once the ARSN-578 changes are published.
— Claude Code
There was a problem hiding this comment.
Yes, arsenal is not yet released.
Review by Claude Code |
SylvainSenechal
left a comment
There was a problem hiding this comment.
reviewed but let's wait a bit before merging, see how we end up doing things in arsenal
Bump arsenal to pick up the new microVersionId format (ts + seq + repGroupId), required by cascaded CRR for loop detection and stale event handling. The resync tool bypasses CloudServer's S3 API, so it generates a random per-instance repGroupId and passes it to updateMicroVersionId() to avoid colliding with concurrent writers. Issue: S3UTILS-234
1d860c7 to
19a46e6
Compare
| "@smithy/util-retry": "^4.0.7", | ||
| "JSONStream": "^1.3.5", | ||
| "arsenal": "git+https://github.com/scality/arsenal#8.2.36", | ||
| "arsenal": "git+https://github.com/scality/arsenal#2c429ab35a5ac82c3dafa5a0296a49a23a9c8a4a", |
There was a problem hiding this comment.
arsenal is pinned to a bare commit hash instead of a tag. No tag exists yet for 2c429ab. Git-based deps in this project should pin to a tag for readability and traceability. Please publish a tag on Arsenal for this commit and reference it here.
— Claude Code
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/1.17 #395 +/- ##
====================================================
+ Coverage 44.90% 44.92% +0.02%
====================================================
Files 88 88
Lines 6456 6459 +3
Branches 1352 1352
====================================================
+ Hits 2899 2902 +3
Misses 3511 3511
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bump arsenal to pick up the new microVersionId format (ts + seq + repGroupId), required by cascaded CRR for loop detection and stale event handling. The resync tool bypasses CloudServer's S3 API, so it generates a random per-instance repGroupId and passes it to updateMicroVersionId() to avoid colliding with concurrent writers.
Issue: S3UTILS-234
Related PRs :
Arsenal : scality/Arsenal#2628
Cloudserver : scality/cloudserver#6179
CloudserverClient : scality/cloudserverclient#24
Backbeat : scality/backbeat#2747