Skip to content

Lockpages, events and timer assorted fixes #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlelli wants to merge 3 commits into
base: master
Choose a base branch
from
+19 −12
Open

Lockpages, events and timer assorted fixes #141

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97a61ff
rt-app: Fix page locking order and remove forced lock_pages override
jlelli Aug 28, 2025
5ba2ec0
Add ftrace events for lockpages and setparam
jlelli Aug 28, 2025
467a784
Set t_first right before the first phase
jlelli Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions src/rt-app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,7 +1130,6 @@ static void set_thread_param(thread_data_t *data, sched_data_t *sched_data)
case idle:
_set_thread_cfs(data, sched_data);
_set_thread_uclamp(data, sched_data);
data->lock_pages = 0; /* forced off */
break;
case deadline:
_set_thread_deadline(data, sched_data);
Expand All @@ -1142,6 +1141,10 @@ static void set_thread_param(thread_data_t *data, sched_data_t *sched_data)
}

data->curr_sched_data = sched_data;

log_ftrace(ft_data.marker_fd, FTRACE_TASK,
"rtapp_task: event=setparam policy=%s",
policy_to_string(sched_data->policy));
}

void setup_thread_gnuplot(thread_data_t *tdata);
Expand Down Expand Up @@ -1199,6 +1202,19 @@ void *thread_body(void *arg)
if (!data->forked)
pthread_barrier_wait(&threads_barrier);

/* Lock pages */
if (data->lock_pages == 1)
{
log_notice("[%d] Locking pages in memory", data->ind);
ret = mlockall(MCL_CURRENT | MCL_FUTURE);
if (ret != 0) {
perror("mlockall");
exit(EXIT_FAILURE);
}
log_ftrace(ft_data.marker_fd, FTRACE_TASK,
"rtapp_task: event=mlockall");
}

t_first = t_zero;

log_notice("[%d] starting thread ...\n", data->ind);
Expand Down Expand Up @@ -1226,6 +1242,8 @@ void *thread_body(void *arg)
* budget as little as possible for the first iteration.
*/

clock_gettime(CLOCK_MONOTONIC, &t_first);

/* Set scheduling policy and print pretty info on stdout */
log_notice("[%d] Starting with %s policy with priority %d",
data->ind, policy_to_string(data->sched_data->policy),
Expand All @@ -1234,17 +1252,6 @@ void *thread_body(void *arg)
set_thread_membind(data, &data->numa_data);
set_thread_taskgroup(data, data->taskgroup_data);

/* Lock pages */
if (data->lock_pages == 1)
{
log_notice("[%d] Locking pages in memory", data->ind);
ret = mlockall(MCL_CURRENT | MCL_FUTURE);
if (ret != 0) {
perror("mlockall");
exit(EXIT_FAILURE);
}
}

/*
* phase - index of current phase in data->phases array
* phase_loop - current iteration of current phase
Expand Down