Add file type filtering support for command options and file uploads - #3596
Merged
Conversation
meditationmind
left a comment
Contributor
There was a problem hiding this comment.
Overall looks fine to me. Could merge this as is, but I've noted a few docs nitpicks below, to make things more consistent with our own docs.
Also, successfully tested both slash commands and modals, and I can PR the slash changes to Poise once this is merged.
Co-authored-by: Meditation Mind <115960723+meditationmind@users.noreply.github.com>
Co-authored-by: Meditation Mind <115960723+meditationmind@users.noreply.github.com>
Co-authored-by: Meditation Mind <115960723+meditationmind@users.noreply.github.com>
meditationmind
approved these changes
Aug 7, 2026
arqunis
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.discord.com/developers/change-log#filter-file-types-in-file-uploads-and-attachment-options
Open Questions:
Image,Video,Audio,Extension(String)could be argued for.but kinda ties into point one with how we want the api to look.