Skip to content

Box {Component,Modal}Interaction::member - #3598

Merged
arqunis merged 2 commits into
serenity-rs:nextfrom
DPlayer234:box-interaction-member
Aug 8, 2026
Merged

Box {Component,Modal}Interaction::member#3598
arqunis merged 2 commits into
serenity-rs:nextfrom
DPlayer234:box-interaction-member

Conversation

@DPlayer234

@DPlayer234 DPlayer234 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

To match what has been done to CommandInteraction in the past and actually make its size reduction useful for Interaction (again?).
Also reduces the size of Event.

64-bit app type sizes without this PR:

ComponentInteraction: 1120 bytes
ModalInteraction: 1096 bytes
Interaction: 1120 bytes
Event: 1120 bytes

With this PR:

ComponentInteraction: 768 bytes
ModalInteraction: 744 bytes
Interaction: 792 bytes
Event: 792 bytes

@github-actions github-actions Bot added the model Related to the `model` module. label Aug 6, 2026
@DPlayer234

Copy link
Copy Markdown
Contributor Author

With this PR, the size difference for the variants within Event is apparently no longer above the threshold to fire clippy::large_enum_variants. Since this repo also lints on allow, I opted to remove the expect entirely.

@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Aug 8, 2026
@arqunis
arqunis merged commit e279617 into serenity-rs:next Aug 8, 2026
25 checks passed
@DPlayer234
DPlayer234 deleted the box-interaction-member branch August 9, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users enhancement An improvement to Serenity. model Related to the `model` module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants