Repository navigation
Conversation
Replace informational: true with target: auto and a 1% threshold, so a PR that drops total coverage by more than 1% fails the project status. Wait for both coverage uploads before reporting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
=======================================
Coverage 45.09% 45.09%
=======================================
Files 65 65
Lines 9552 9552
=======================================
Hits 4307 4307
Misses 5245 5245 🚀 New features to boost your workflow:
|
Collaborator
|
@tschm This is very cool. I didn't know about this technique. |
Collaborator
|
@wangxiaoying I am tempted to merge this PR :) Atleast no PR can reduce coverage with this change. I will let this comment stay for sometime, in case you have any concerns. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Right now
codecov.ymlsets the project status toinformational: true, so a drop in coverage can never fail a PR. This PR switches it to a ratchet:target: autowiththreshold: 1%: the project status fails if total coverage falls more than 1% below the base commit. Using the base commit instead of a fixed number means nobody has to bump the target by hand as coverage improves (it's 44.8% onmaintoday).codecov.notify.after_n_builds: 2(and the same for the PR comment):ci.ymluploads two reports per commit (unit-testsandintegration-tests). Without this setting Codecov can calculate the status from whichever upload arrives first, show a false drop and fail.The patch target (60%) is unchanged.
Verification
curl --data-binary @codecov.yml https://codecov.io/validatereturnsValid!.Not addressed
fail_ci_if_error: falseon both upload steps inci.ymlstays as it is. If it weretrue, a Codecov outage or a fork PR withoutCODECOV_TOKENwould turn the whole test job red. Withafter_n_builds: 2, a missing upload means no project status gets posted, rather than a failing one.Closes #977
🤖 Generated with Claude Code