Skip to content

fix: update unchained-client openapi generator config - #11814

Closed
0xApotheosis wants to merge 1 commit into
developfrom
fix/unchained-client-generate
Closed

fix: update unchained-client openapi generator config#11814
0xApotheosis wants to merge 1 commit into
developfrom
fix/unchained-client-generate

Conversation

@0xApotheosis

@0xApotheosis 0xApotheosis commented Feb 10, 2026

Copy link
Copy Markdown
Member

Description

The yarn workspace @shapeshiftoss/unchained-client generate command fails because the upstream unchained repo removed the Arbitrum Nova coinstack in shapeshift/unchained#1258 (merged 2026-02-09).

This PR makes three changes to openapitools.json:

  • Remove the arbitrumNova generator entry — the swagger spec URL returns 404 since the coinstack was deleted upstream
  • Update cosmos spec URL — point to develop branch instead of the cosmos fork branch (now merged into develop)
  • Update mayachain spec URL — point to develop branch instead of the mayachain fork branch (now merged into develop)

Note: This is a minimal fix to unblock the generate command. A follow-up PR will handle the full removal of Arbitrum Nova chain support from the web app.

Issue (if applicable)

N/A — the upstream unchained repo removed arbitrum-nova in shapeshift/unchained#1258

Risk

Low. This only changes the OpenAPI code generation config. No runtime code is affected. The existing generated arbitrumNova client code remains untouched (it's gitignored and only regenerated on explicit yarn generate runs).

No protocols, transaction types, wallets or contract interactions are affected.

Testing

Engineering

  1. yarn workspace @shapeshiftoss/unchained-client generate — should complete successfully with all 18 generators passing (was failing on arbitrumNova before)
  2. Verify no other generators are affected

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated API generation configurations for Cosmos and Mayachain to use develop branch sources.
    • Removed ArbitrumNova configuration.

@0xApotheosis
0xApotheosis requested a review from a team as a code owner February 10, 2026 01:27
@coderabbitai

coderabbitai Bot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@0xApotheosis has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

This PR updates the OpenAPI tools configuration for the unchained-client package by switching cosmos and mayachain API source URLs from alternative locations to the GitHub develop branch URL, and removes the unused arbitrumNova configuration block entirely.

Changes

Cohort / File(s) Summary
API Configuration Updates
packages/unchained-client/openapitools.json
Updated cosmos inputSpec from CDN URL to raw.githubusercontent.com/develop branch URL; updated mayachain inputSpec from refs/heads/mayachain to develop branch URL; removed arbitrumNova configuration block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • gomesalexandre
  • kaladinlight

Poem

🐰 URLs now point to develop's way,
No more arbitrum nova in play,
GitHub branches guide the flow,
Configuration's cleaner now, I'd say! 🔗

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: updating the OpenAPI generator configuration in the unchained-client package. It directly addresses the primary objective of unblocking the generate command by updating configuration references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/unchained-client-generate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Remove arbitrumNova generator entry and its source module from
unchained-client (coinstack removed upstream in
shapeshift/unchained#1258). Update cosmos/mayachain spec URLs
to point to develop branch now that they've been merged from their
long-running fork branches.
@0xApotheosis
0xApotheosis force-pushed the fix/unchained-client-generate branch from 6e61014 to 116838a Compare February 10, 2026 01:35
@0xApotheosis

Copy link
Copy Markdown
Member Author

Closing in favor of #11815 which includes the full chain removal — the package dependency graph means we can't remove arbitrumNova from unchained-client without also removing it from chain-adapters and everything downstream.

@kaladinlight
kaladinlight deleted the fix/unchained-client-generate branch May 15, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant