Say who can see each custom field where its value is edited and shown - #320
Merged
Merged
Conversation
The member editor listed custom fields as a bare label and an input, so "wait, was that one public?" meant leaving the member, opening Settings, finding the field, and coming back. The level lives on the definition and applies to every member, which is exactly why the editor could not answer the question on its own. Each field row in the editor now carries its privacy level as a small tinted word (Private, Friends only, Public), and shows the same "activates on" note the settings card uses when a raise is waiting out a grace period. The member detail view gets the same tag beside each "Name: value" line, so the two views of a member never disagree. Display only, on purpose. Changing the level stays in Settings, since a raise there runs the step-up and grace-period flow and one write path per level keeps that in one place. Word rather than icon, because a badge alone says nothing for private, and private is the one answer people open the editor to confirm. The tag component sits beside the existing display-only label in the privacy select module, so the vocabulary and tones stay in the one file that owns them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The member editor listed custom fields as a bare label and an input, with nothing about who can see them. The level lives on the field definition and applies to every member, which is exactly why "wait, was that one public?" could not be answered from the editor: it meant leaving the member, opening Settings, finding the field, and coming back.
What this does. Each custom field in the member editor carries its privacy level beside the label as a small tinted word (Private, Friends only, Public), and shows the same "activates on" note the settings card uses when a raise is waiting out a grace period. The member detail view gets the same tag after each "Name: value" line, so the two views of a member never disagree about who can see a field.
Display only, on purpose. Changing the level stays in Settings. A raise there runs the step-up and grace-period flow, and one write path per level keeps that in one place. Word rather than icon, because a badge alone says nothing for private, and private is the one answer people open the editor to confirm. No link to Settings either; easy to add if people want it.
Where it lives. The tag component sits beside the existing display-only label in the privacy select module, so the vocabulary and the tones stay in the one file that owns them. Private is muted, Friends only is sky, Public is amber and slightly bolder, the same amber as the staged-raise notes since both mean "visible, or about to be".
Web only, no API change. Type-check and lint clean; verified in the browser in light and dark with all four states on one member (private, friends, public, and a friends field with a public raise staged).