Fix some symbolic icons not rendering in Gtk4 - #541
Open
newhoa wants to merge 1 commit into
Open
Conversation
This ungroups elements in a lot of symbolic icons as Gtk4 is not rendering icons with grouped elements correctly. While this is really a Gtk4 issue, this should resolve the issue on our end for now. Fixes shimmerproject#539
Contributor
|
GTK 4.16 - works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ungroups elements in a lot of symbolic icons as Gtk4 is not rendering icons with grouped elements correctly. While this is really a Gtk4 issue, this should resolve the issue on our end for now.
The method for this was to use some scripts I created to render the icons in Gtk4, make a file list of non-rendering icons, then run this command on them:
xargs -d '\n' -I {} inkscape "{}" --actions="select-all:all; selection-ungroup" --export-overwrite --export-filename="{}" < files.txtIf anyone could test this out I'd appreciate it but they seem to render fine now for me in my test script and in gtk4-widget-factory and gtk4-demo using Debian unstable and Gtk 4.22.4
Thanks!
Fixes #539