Repository navigation
Track nested classes correctly in CodeBlockAnalyser - #89
Merged
Merged
Conversation
CodeBlockAnalyser kept the current class in one variable and the anonymous class state in one flag. Nested classes broke both: - A named class declared inside a method reset the current class when the traversal left it. The next method of the outer class then threw "Found class method without a class, should never happen". - An anonymous class inside an anonymous class cleared the flag too early. The methods after the inner class were then analysed and reported as methods of the outer named class. A rule that calls getMethodReflection() then failed, because such a method does not exist. The analyser now keeps a stack of the entered classes. The top of the stack is the class of the current method. Co-Authored-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeBlockAnalyserkeeps the current class in one variable and the anonymous class state in one flag. Nested classes break both:null. The next method of the outer class then throwsLogicException: Found class method without a class, should never happen.Method App\AnonHost::b has no coverage. A rule that callsgetMethodReflection()then fails, because such a method does not exist.Now the analyser keeps a stack of the entered classes. The top of the stack is the class of the current method.
master.Co-Authored-By: Claude Code