Repository navigation
Skip dead lines in .cov files - #91
Merged
Merged
Conversation
php-code-coverage stores null for a dead (unreachable) line, for example a break after a return in a switch. PhpUnitCoverageExtractor accepted only arrays and threw a LogicException on null. So check, patch-coverage, merge and convert stopped with an internal error for every .cov file that contains one such line. The extractor now skips null lines, as the PHPUnit Clover and Cobertura reports do. A dead line is not executable, so no rule can require its coverage. Co-Authored-By: Claude Code
janedbal
marked this pull request as ready for review
October 20, 2026 07:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php-code-coverage stores
nullfor a dead (unreachable) line in.covfiles.PhpUnitCoverageExtractoraccepts only arrays, so it throws onnull. Every command that reads.cov(check,patch-coverage,merge,convert) then stops with an internal error.One dead line in the coverage scope is enough. Example from a real PHPUnit 13 + Xdebug run:
The
nullcomes in two cases. If no test runs the file, php-code-coverage finds dead lines by static analysis. If a test runs the file, Xdebug reports the line as dead.Now the extractor skips
nulllines, as the PHPUnit Clover and Cobertura reports do. A dead line is not executable, so no rule can require its coverage.nullline. It fails onmaster.Co-Authored-By: Claude Code