Skip to content

feat: update GenericModal with new image and link #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shramee merged 2 commits into from
Jul 24, 2025
Merged

feat: update GenericModal with new image and link #291

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5bacdc
feat: update GenericModal with new image and link
dpinones Jul 22, 2025
ffc6122
resolve comments
dpinones Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added app/client/public/developer_basecamp_13.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions app/client/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,19 +73,19 @@ function App() {
<StarknetProvider>
<QueryClientProvider client={queryClient}>
<ThemeProvider theme={darkTheme}>
{/* <GenericModal
<GenericModal
id="starknet_hackathon"
open={open}
handleClose={handleClose}
handleOpen={handleOpen}
image_src="/starknet_hackathon.png"
image_alt="Starknet Hackathon: Re{ignite}"
image_src="/developer_basecamp_13.png"
image_alt="Starknet Developer Basecamp 13"
// title="Starknet Hackathon"
// date="Starting May 12"
// description="From idea to MVP: Build real solutions, form teams, and compete for prizes."
// button_text="Register for Hackathon"
link="https://www.hackquest.io/hackathons/Starknet-Hackathon-Re%7Bignite%7D?utm=starklings"
/> */}
link="https://us06web.zoom.us/webinar/register/6517491159098/WN_VnPGmzseSBmi7FkNcPpRmQ#/registration"
/>

<BasicLayout>
<>
Expand Down
14 changes: 12 additions & 2 deletions app/client/src/components/modals/GenericModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export const GenericModal = ({ id, open, handleClose, handleOpen, image_src, ima
height: "100%",
}}
>
<a href={link} style={{ display: 'block' }}>
<a href={link} onClick={(e) => { e.preventDefault(); openInNewTab(link); }} style={{ display: 'block' }}>

@shramee shramee Jul 22, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use target="_blank" here.

@dpinones dpinones Jul 24, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

<img
onClick={() => openInNewTab(link)}
src={image_src}
Expand All @@ -123,6 +123,7 @@ export const GenericModal = ({ id, open, handleClose, handleOpen, image_src, ima
width: "100%",
height: "100%",
display: "block",
cursor: "pointer",

@shramee shramee Jul 22, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary because the image is in a anchor tags...

@dpinones dpinones Jul 24, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

}}
/>
</a>
Expand All @@ -132,8 +133,12 @@ export const GenericModal = ({ id, open, handleClose, handleOpen, image_src, ima
onClick={handleDontShowAgain}
sx={{
color: "white",
backgroundColor: "#4862b0",
borderRadius: 2,
py: 1.5,
"&:hover": {
backgroundColor: "#5a7bd0",
},
}}
>
Don't show again
Expand Down Expand Up @@ -187,11 +192,16 @@ export const GenericModal = ({ id, open, handleClose, handleOpen, image_src, ima
variant="outlined"
onClick={handleDontShowAgain}
sx={{
borderColor: "rgba(255, 255, 255, 0.5)",
borderColor: "#4862b0",
color: "white",
backgroundColor: "#4862b0",
borderRadius: 2,
flex: "0 1 22em",
py: 1,
"&:hover": {
backgroundColor: "#5a7bd0",
borderColor: "#5a7bd0",
},
}}
>
Don't show again
Expand Down