fix: populate Modalias for NVMe disks#158
Open
rothgar wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Populates DeviceProperties.Modalias for NVMe namespaces by reading the modalias from an alternate sysfs path when the usual /device/modalias entry is missing, aligning NVMe behavior with SCSI/ATA devices.
Changes:
- Replace direct sysfs modalias read with
readBlockDeviceModalias()fallback logic. - Add
readBlockDeviceModalias()helper to read/device/modaliasand fall back to/device/device/modalias. - Add internal tests covering both “SCSI-style” and “NVMe-style” modalias layouts and precedence.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
block/device.go |
Updates DeviceProperties.Modalias field comment to describe the fallback sysfs location. |
block/device_linux.go |
Uses a helper to read modalias with a fallback for NVMe namespaces. |
block/device_linux_internal_test.go |
Adds unit tests to validate modalias fallback and precedence behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DeviceProperties.Modalias was empty for NVMe namespaces because the kernel exposes the PCI device at a different path than SCSI/ATA. Signed-off-by: Justin Garrison <justin.garrison@siderolabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeviceProperties.Modalias was empty for NVMe namespaces because the kernel exposes the PCI device at a different path than SCSI/ATA.