feat: expose Vendor on DeviceProperties#159
Open
rothgar wants to merge 1 commit into
Open
Conversation
Read /sys/block/<dev>/device/vendor and surface it as DeviceProperties.Vendor. Populated for SCSI/SAS disks (real SCSI subsystem) and reported as "ATA" for SATA disks (libata convention). Empty for NVMe, which does not expose a vendor string at this path Signed-off-by: Justin Garrison <justin.garrison@siderolabs.com>
There was a problem hiding this comment.
Pull request overview
This PR exposes a device vendor string via DeviceProperties.Vendor, sourced from Linux sysfs (/sys/block/<dev>/device/vendor), to surface vendor info for SCSI/SAS devices and the libata-reported "ATA" vendor value for SATA devices.
Changes:
- Add
Vendorto the publicDevicePropertiesstruct. - Populate
DeviceProperties.Vendorin LinuxGetProperties()by readingdevice/vendorfrom sysfs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
block/device.go |
Extends DeviceProperties with a new Vendor field. |
block/device_linux.go |
Reads and assigns sysfs device/vendor into DeviceProperties.Vendor in GetProperties(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
46
to
50
| // Model from /sys/block/*/device/model. | ||
| Model string | ||
| // Vendor from /sys/block/<dev>/device/vendor. | ||
| Vendor string | ||
| // Serial /sys/block/<dev>/device/serial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read /sys/block//device/vendor and surface it as DeviceProperties.Vendor. Populated for SCSI/SAS disks (real SCSI subsystem) and reported as "ATA" for SATA disks (libata convention). Empty for NVMe, which does not expose a vendor string at this path