Skip to content

Do not clear delivered notifications on app activate - #6321

Open
polo2187 wants to merge 1 commit into
signalapp:mainfrom
polo2187:fix/ios-notification-center-dismissal
Open

Do not clear delivered notifications on app activate#6321
polo2187 wants to merge 1 commit into
signalapp:mainfrom
polo2187:fix/ios-notification-center-dismissal

Conversation

@polo2187

Copy link
Copy Markdown

Fixes #6320

First time contributor checklist

Contributor checklist

  • My commits are rebased on the latest main branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
  • iPhone 15 Pro, iOS 26.6

Description

Signal iOS was clearing delivered notifications from Apple Notification Center when the app was opened.

This change stops removing delivered notifications in clearNotificationsForAppActivate() and only clears pending notifications there.

Delivered notifications should remain visible until the related conversation is actually opened/read and removed through the existing thread/message-specific cancellation paths.

Testing

  • Receive one or more Signal messages.
  • Confirm notifications are visible in Notification Center.
  • Open Signal without opening the related conversation.
  • Verify notifications remain visible in Notification Center.
  • Open the conversation.
  • Verify the corresponding notifications are dismissed through existing cancellation logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS: Signal notifications disappear from Notification Center when opening the app

1 participant