-
-
Notifications
You must be signed in to change notification settings - Fork 7
Log Windows updating the FW Lite MSIX package #2576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
59 changes: 59 additions & 0 deletions
59
backend/FwLite/FwLiteMaui/Platforms/Windows/PackageUpdateLogger.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| using Windows.ApplicationModel; | ||
| using Microsoft.Extensions.Logging; | ||
|
|
||
| namespace FwLiteMaui; | ||
|
|
||
| /// <summary> | ||
| /// Logs Windows updating our own MSIX package. The OS stages an update on its own schedule and registers it | ||
| /// at activation, force-terminating this process if it's running, which otherwise leaves nothing in our log. | ||
| /// </summary> | ||
| public class PackageUpdateLogger(ILogger<PackageUpdateLogger> logger) : IMauiInitializeService | ||
| { | ||
| //field, not a local: the subscription stops firing once the catalog is collected | ||
| private PackageCatalog? _packageCatalog; | ||
| private int _loggedProgressDecile = -1; | ||
|
|
||
| public void Initialize(IServiceProvider services) | ||
| { | ||
| try | ||
| { | ||
| _packageCatalog = PackageCatalog.OpenForCurrentPackage(); | ||
| } | ||
| catch (Exception e) | ||
| { | ||
| logger.LogWarning(e, "Unable to open the package catalog, OS package updates won't be logged"); | ||
| return; | ||
| } | ||
|
|
||
| _packageCatalog.PackageUpdating += OnPackageUpdating; | ||
| } | ||
|
|
||
| private void OnPackageUpdating(PackageCatalog sender, PackageUpdatingEventArgs args) | ||
| { | ||
| var version = FormatVersion(args.TargetPackage); | ||
| if (args.ErrorCode is { HResult: not 0 }) | ||
| { | ||
| logger.LogError(args.ErrorCode, "Windows failed to update this app to {TargetVersion}", version); | ||
| return; | ||
| } | ||
|
|
||
| if (args.IsComplete) | ||
| { | ||
| logger.LogInformation("Windows finished updating this app to {TargetVersion}", version); | ||
| return; | ||
| } | ||
|
|
||
| //progress fires often, so only log each 10% step | ||
| var decile = (int)(args.Progress / 10); | ||
| if (decile == _loggedProgressDecile) return; | ||
| _loggedProgressDecile = decile; | ||
| logger.LogInformation("Windows is updating this app to {TargetVersion}: {Progress}%", version, args.Progress); | ||
|
hahn-kev marked this conversation as resolved.
|
||
| } | ||
|
|
||
| private static string FormatVersion(Package? package) | ||
| { | ||
| if (package is null) return "unknown"; | ||
| var version = package.Id.Version; | ||
| return $"{version.Major}.{version.Minor}.{version.Build}.{version.Revision}"; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.