Skip to content

SF-3838 Add date and text filter on onboarding requests tab - #4024

Open
RaymondLuong3 wants to merge 3 commits into
masterfrom
feature/sf-3838-onboarding-filter
Open

SF-3838 Add date and text filter on onboarding requests tab#4024
RaymondLuong3 wants to merge 3 commits into
masterfrom
feature/sf-3838-onboarding-filter

Conversation

@RaymondLuong3

@RaymondLuong3 RaymondLuong3 commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

This PR adds the logic to allow filtering onboarding requests by date and strings in the request object. A new SearchRecordsComponent is now shared between the onboarding requests tab and the serval builds tab. Slight modifications were made to the template in the serval builds tab to align with the template in the Onboarding Requests tab.

Before
Onboarding No Search

After
Onboarding Search

Before
Serval Builds Before

After
Serval Builds After


This change is Reviewable

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.16%. Comparing base (1b6cdcc) to head (8f6ed2e).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../serval-administration/search-records.component.ts 20.00% 4 Missing ⚠️
...boarding-requests/onboarding-requests.component.ts 96.07% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4024      +/-   ##
==========================================
+ Coverage   81.04%   81.16%   +0.11%     
==========================================
  Files         660      661       +1     
  Lines       43014    43087      +73     
  Branches     7050     7066      +16     
==========================================
+ Hits        34861    34971     +110     
+ Misses       6981     6943      -38     
- Partials     1172     1173       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@RaymondLuong3
RaymondLuong3 force-pushed the feature/sf-3838-onboarding-filter branch from 4e09f28 to 8f6ed2e Compare August 6, 2026 17:20
@RaymondLuong3 RaymondLuong3 added will require testing PR should not be merged until testers confirm testing is complete e2e Run e2e tests for this pull request labels Aug 6, 2026
@RaymondLuong3
RaymondLuong3 marked this pull request as ready for review August 6, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant