SF-3882 Remove SMT Translation Suggestions

[pmachapman]

This change is 

[codecov]

Codecov Report

❌ Patch coverage is 91.97531% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.66%. Comparing base (13ccef1) to head (a959b5e).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...SIL.XForge.Scripture/Services/MachineApiService.cs	90.08%	3 Missing and 9 partials ⚠️
...slate/draft-generation/draft-generation.service.ts	33.33%	4 Missing ⚠️
...XForge.Scripture/Services/MachineProjectService.cs	97.08%	0 Missing and 4 partials ⚠️
.../SIL.XForge.Scripture/Services/SFProjectService.cs	66.66%	1 Missing and 1 partial ⚠️
...val-administration/job-details-dialog.component.ts	0.00%	1 Missing ⚠️
...e/ClientApp/src/app/settings/settings.component.ts	50.00%	0 Missing and 1 partial ⚠️
...ntApp/src/app/translate/editor/editor.component.ts	93.33%	1 Missing ⚠️
...XForge.Scripture/Services/PreTranslationService.cs	94.11%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4025      +/-   ##
==========================================
- Coverage   81.06%   80.66%   -0.40%     
==========================================
  Files         660      653       -7     
  Lines       43036    41515    -1521     
  Branches     7057     6824     -233     
==========================================
- Hits        34887    33488    -1399     
+ Misses       6977     6874     -103     
+ Partials     1172     1153      -19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[github-actions]

📸 Screenshot diff deployed! (3 changes)

View the visual diff at: https://pr-4025--sf-screenshot-diffs.netlify.app

[Nateowami]

@Nateowami made 1 comment.
Reviewable status: 0 of 94 files reviewed, all discussions resolved.

---

src/RealtimeServer/scriptureforge/models/sf-project-user-config-test-data.ts line 13 at r2 (raw file):

    confidenceThreshold: 0.2,
    transliterateBiblicalTerms: false,
    translationSuggestionsEnabled: false,

I'm surprised to see this property remains, rather than being migrated off.

[Nateowami]

(I guess I should state my actual question, which is whether this was a deliberate decision and why)

[pmachapman]

@pmachapman made 1 comment.
Reviewable status: 0 of 94 files reviewed, all discussions resolved (waiting on Nateowami).

---

src/RealtimeServer/scriptureforge/models/sf-project-user-config-test-data.ts line 13 at r2 (raw file):

Previously, Nateowami wrote…

I'm surprised to see this property remains, rather than being migrated off.

If we remove the property outright in this PR and deploy to live, anyone with the older code base will cause exceptions as the missing property is attempted to be read and undefined is returned.

I've take the approach of removing references to it in the frontend and backend code, and marking it as obsolete. We will be able to remove it sometime in the future (maybe in 4-6 months time?) and very few if any exceptions will result, as nearly all users will be using a codebase that doesn't reference the property.