silx.gui.hdf5.Hdf5TreeView: Allow to set Hdf5TreeView's model in __init__#4626
Draft
t20100 wants to merge 1 commit into
Draft
silx.gui.hdf5.Hdf5TreeView: Allow to set Hdf5TreeView's model in __init__#4626t20100 wants to merge 1 commit into
t20100 wants to merge 1 commit into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<Module or Topic>: <Action> <Summary>(see contributing guidelines)PR summary
Merge PR #4616 first!
This PR:
Hdf5TreeModel'sdestroyedsignal ifownFiles=True= when it is needed.Viewer, avoids the creation of a first default model inHdf5TreeViewwithownFiles=Truethat is immediately replaced by a model withownFiles=False.This is achieved by adding an optional
modelargument toHdf5TreeViewto pass a custom model.The alternative would be through inheritance and overriding
Hdf5TreeView.createDefaultModel.This PR mitigates issue #4605 by avoiding using the
destroyedsignal when it is not needed, but it does not fixfunctools.partialissue. PR #4616 fixes it.With this PR, ewoksfluo segfault #4605 no longer occurs.
AI Disclosure