Fix schedule generation, APR calculations, and rebate handling - #71

Open

Thorium wants to merge 18 commits into

simontreanor:mainfrom

Thorium:integration-critical-fixes

Commits on Jul 8, 2026

Fix reschedule auto-generated plans and rollover fee rebate day basis

Thorium
and
claude
committed
6fdfb58
Add regression tests for auto-generated reschedule and rollover rebate

Thorium
and
claude
committed
1cbc42a
Fix unit-period detection and schedule generation edge cases

Thorium
and
claude
committed
3fcbbfe
Fix APR calculation per Reg Z Appendix J and harden the solver

Thorium
and
claude
committed
c2653f7
Add regression tests for APR and unit-period fixes

Thorium
and
claude
committed
d2a2d50
Fix statutory fee rebate crash and settlement figure composed with wrong rebate

Thorium
and
claude
committed
94433e6
Fix same-day partial payments ignored by settlement quotes and refunds on scheduled days

Thorium
and
claude
committed
ea6d07b
Fail fast with a descriptive error when amortising an empty payment schedule

Thorium
and
claude
committed
59ad126
Fix AddChargesAndInterest apportionment double-counting charges and interest

Thorium
and
claude
committed
da75eac
Apply failed-payment charges even when no payment is due on the day

Thorium
and
claude
committed
4b50647
Fix final-payment adjustment producing negative payments and doubled principal on day-0 schedules

Thorium
and
claude
committed
782cd24
Fail early with a descriptive message when the schedule config yields no payment days

Thorium
and
claude
committed
d8115f2
Fix level-payment solver failing under interest caps and at high interest rates

Thorium
and
claude
committed
35599a7
Add regression tests for schedule solver and final-payment adjustment fixes

Thorium
and
claude
committed
e27716c
Merge branch 'schedule-solver-fixes' into integration-critical-fixes
Thorium
committed
017a5f0
Merge branch 'apr-unit-period-fixes' into integration-critical-fixes
Thorium
committed
c665106
Merge branch 'refinancing-fixes' into integration-critical-fixes
Thorium
committed
41525ea
Align empty-schedule regression test with the earlier basic-schedule validation

Thorium
and
claude
committed
fbe1857

Navigation Menu

Fix schedule generation, APR calculations, and rebate handling - #71

Fix schedule generation, APR calculations, and rebate handling#71
Thorium wants to merge 18 commits into
simontreanor:mainfrom
Thorium:integration-critical-fixes

Commits on Jul 8, 2026

Fix reschedule auto-generated plans and rollover fee rebate day basis

Add regression tests for auto-generated reschedule and rollover rebate

Fix unit-period detection and schedule generation edge cases

Fix APR calculation per Reg Z Appendix J and harden the solver

Add regression tests for APR and unit-period fixes

Fix statutory fee rebate crash and settlement figure composed with wrong rebate

Fix same-day partial payments ignored by settlement quotes and refunds on scheduled days

Fail fast with a descriptive error when amortising an empty payment schedule

Fix AddChargesAndInterest apportionment double-counting charges and interest

Apply failed-payment charges even when no payment is due on the day

Fix final-payment adjustment producing negative payments and doubled principal on day-0 schedules

Fail early with a descriptive message when the schedule config yields no payment days

Fix level-payment solver failing under interest caps and at high interest rates

Add regression tests for schedule solver and final-payment adjustment fixes

Merge branch 'schedule-solver-fixes' into integration-critical-fixes

Merge branch 'apr-unit-period-fixes' into integration-critical-fixes

Merge branch 'refinancing-fixes' into integration-critical-fixes

Align empty-schedule regression test with the earlier basic-schedule validation