feat(deploy-modal): logs section + URL-driven log selection #4522
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| export { Logs } from './logs' | ||
| export { Versions } from './versions' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,183 @@ | ||||||
| 'use client' | ||||||
|
|
||||||
| import { useMemo } from 'react' | ||||||
| import { formatDateTime, formatDuration } from '@sim/utils/formatting' | ||||||
| import clsx from 'clsx' | ||||||
| import { useParams, useRouter } from 'next/navigation' | ||||||
| import { Skeleton } from '@/components/emcn' | ||||||
| import type { WorkflowLogSummary } from '@/lib/api/contracts/logs' | ||||||
| import { type LogFilters, useLogsList } from '@/hooks/queries/logs' | ||||||
| import { | ||||||
| getDisplayStatus, | ||||||
| StatusBadge, | ||||||
| TriggerBadge, | ||||||
| } from '@/app/workspace/[workspaceId]/logs/utils' | ||||||
|
Contributor
There was a problem hiding this comment.
Context Used: Core architecture principles for the Sim app (source) Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||||||
|
|
||||||
| const HEADER_TEXT_CLASS = 'font-medium text-[var(--text-tertiary)] text-caption' | ||||||
| const ROW_TEXT_CLASS = 'font-medium text-[var(--text-primary)] text-caption' | ||||||
| const COLUMN_BASE_CLASS = 'flex-shrink-0' | ||||||
|
|
||||||
| const COLUMN_WIDTHS = { | ||||||
| STATUS: 'w-[100px]', | ||||||
| TRIGGER: 'w-[120px]', | ||||||
| DURATION: 'w-[80px]', | ||||||
| TIMESTAMP: 'flex-1', | ||||||
| } as const | ||||||
|
|
||||||
| const LOGS_LIMIT = 5 as const | ||||||
|
|
||||||
| const BASE_FILTERS = { | ||||||
| timeRange: 'All time', | ||||||
| level: 'all', | ||||||
| folderIds: [] as string[], | ||||||
| triggers: [] as string[], | ||||||
| searchQuery: '', | ||||||
| limit: LOGS_LIMIT, | ||||||
| sortBy: 'date', | ||||||
| sortOrder: 'desc', | ||||||
| } as const satisfies Omit<LogFilters, 'workflowIds'> | ||||||
|
|
||||||
| interface LogsProps { | ||||||
| workflowId: string | null | ||||||
| } | ||||||
|
|
||||||
| /** | ||||||
| * Displays the latest workflow runs inside the deploy modal. | ||||||
| * Clicking a row opens that execution in the Logs page. | ||||||
| */ | ||||||
| export function Logs({ workflowId }: LogsProps) { | ||||||
| const params = useParams() | ||||||
| const router = useRouter() | ||||||
| const workspaceId = params?.workspaceId as string | undefined | ||||||
|
|
||||||
| const filters = useMemo<LogFilters>( | ||||||
| () => ({ ...BASE_FILTERS, workflowIds: workflowId ? [workflowId] : [] }), | ||||||
| [workflowId] | ||||||
| ) | ||||||
|
|
||||||
| const { data, isLoading } = useLogsList(workspaceId, filters, { | ||||||
| enabled: Boolean(workflowId) && Boolean(workspaceId), | ||||||
| }) | ||||||
|
|
||||||
| const logs = useMemo<WorkflowLogSummary[]>( | ||||||
| () => (data?.pages?.[0]?.logs ?? []).slice(0, LOGS_LIMIT), | ||||||
| [data] | ||||||
| ) | ||||||
|
|
||||||
| const handleRowClick = (log: WorkflowLogSummary) => { | ||||||
| if (!workspaceId || !log.executionId) return | ||||||
| router.push(`/workspace/${workspaceId}/logs?executionId=${log.executionId}`) | ||||||
| } | ||||||
|
|
||||||
| if (isLoading && logs.length === 0) { | ||||||
| return ( | ||||||
| <div className='overflow-hidden rounded-sm border border-[var(--border)]'> | ||||||
| <div className='flex h-[30px] items-center bg-[var(--surface-1)] px-4'> | ||||||
| <div className={clsx(COLUMN_WIDTHS.STATUS, COLUMN_BASE_CLASS)}> | ||||||
| <Skeleton className='h-[12px] w-[44px]' /> | ||||||
| </div> | ||||||
| <div className={clsx(COLUMN_WIDTHS.TRIGGER, COLUMN_BASE_CLASS)}> | ||||||
| <Skeleton className='h-[12px] w-[52px]' /> | ||||||
| </div> | ||||||
| <div className={clsx(COLUMN_WIDTHS.DURATION, COLUMN_BASE_CLASS)}> | ||||||
| <Skeleton className='h-[12px] w-[56px]' /> | ||||||
| </div> | ||||||
| <div className={clsx(COLUMN_WIDTHS.TIMESTAMP, 'min-w-0')}> | ||||||
| <Skeleton className='h-[12px] w-[68px]' /> | ||||||
| </div> | ||||||
| </div> | ||||||
| <div className='bg-[var(--surface-2)]'> | ||||||
| {[0, 1, 2].map((i) => ( | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||
| <div key={i} className='flex h-[36px] items-center px-4'> | ||||||
| <div className={clsx(COLUMN_WIDTHS.STATUS, COLUMN_BASE_CLASS, 'min-w-0 pr-2')}> | ||||||
| <Skeleton className='h-[18px] w-[60px] rounded-sm' /> | ||||||
| </div> | ||||||
| <div className={clsx(COLUMN_WIDTHS.TRIGGER, COLUMN_BASE_CLASS, 'min-w-0 pr-2')}> | ||||||
| <Skeleton className='h-[18px] w-[70px] rounded-sm' /> | ||||||
| </div> | ||||||
| <div className={clsx(COLUMN_WIDTHS.DURATION, COLUMN_BASE_CLASS, 'min-w-0 pr-2')}> | ||||||
| <Skeleton className='h-[12px] w-[48px]' /> | ||||||
| </div> | ||||||
| <div className={clsx(COLUMN_WIDTHS.TIMESTAMP, 'min-w-0')}> | ||||||
| <Skeleton className='h-[12px] w-[160px]' /> | ||||||
| </div> | ||||||
| </div> | ||||||
| ))} | ||||||
| </div> | ||||||
| </div> | ||||||
| ) | ||||||
| } | ||||||
|
|
||||||
| if (logs.length === 0) { | ||||||
| return ( | ||||||
| <div className='flex h-[80px] items-center justify-center rounded-sm border border-[var(--border)] text-[var(--text-placeholder)] text-small'> | ||||||
| No runs yet | ||||||
| </div> | ||||||
| ) | ||||||
| } | ||||||
|
|
||||||
| return ( | ||||||
| <div className='overflow-hidden rounded-sm border border-[var(--border)]'> | ||||||
| <div className='flex h-[30px] items-center bg-[var(--surface-1)] px-4'> | ||||||
| <div className={clsx(COLUMN_WIDTHS.STATUS, COLUMN_BASE_CLASS)}> | ||||||
| <span className={HEADER_TEXT_CLASS}>Status</span> | ||||||
| </div> | ||||||
| <div className={clsx(COLUMN_WIDTHS.TRIGGER, COLUMN_BASE_CLASS)}> | ||||||
| <span className={HEADER_TEXT_CLASS}>Trigger</span> | ||||||
| </div> | ||||||
| <div className={clsx(COLUMN_WIDTHS.DURATION, COLUMN_BASE_CLASS)}> | ||||||
| <span className={HEADER_TEXT_CLASS}>Duration</span> | ||||||
| </div> | ||||||
| <div className={clsx(COLUMN_WIDTHS.TIMESTAMP, 'min-w-0')}> | ||||||
| <span className={HEADER_TEXT_CLASS}>Timestamp</span> | ||||||
| </div> | ||||||
| </div> | ||||||
|
|
||||||
| <div className='bg-[var(--surface-2)]'> | ||||||
| {logs.map((log) => { | ||||||
| const isClickable = Boolean(log.executionId && workspaceId) | ||||||
| return ( | ||||||
| <div | ||||||
| key={log.id} | ||||||
| className={clsx( | ||||||
| 'flex h-[36px] items-center px-4 transition-colors duration-100', | ||||||
| isClickable | ||||||
| ? 'cursor-pointer hover-hover:bg-[var(--surface-6)] dark:hover-hover:bg-[var(--border)]' | ||||||
| : 'cursor-default' | ||||||
| )} | ||||||
| onClick={isClickable ? () => handleRowClick(log) : undefined} | ||||||
| > | ||||||
| <div className={clsx(COLUMN_WIDTHS.STATUS, COLUMN_BASE_CLASS, 'min-w-0 pr-2')}> | ||||||
| <StatusBadge status={getDisplayStatus(log.status)} /> | ||||||
| </div> | ||||||
|
|
||||||
| <div className={clsx(COLUMN_WIDTHS.TRIGGER, COLUMN_BASE_CLASS, 'min-w-0 pr-2')}> | ||||||
| {log.trigger ? ( | ||||||
| <TriggerBadge trigger={log.trigger} /> | ||||||
| ) : ( | ||||||
| <span className={ROW_TEXT_CLASS}>—</span> | ||||||
| )} | ||||||
| </div> | ||||||
|
|
||||||
| <div className={clsx(COLUMN_WIDTHS.DURATION, COLUMN_BASE_CLASS, 'min-w-0 pr-2')}> | ||||||
| <span | ||||||
| className={clsx('block truncate text-[var(--text-tertiary)]', ROW_TEXT_CLASS)} | ||||||
| > | ||||||
| {formatDuration(log.duration, { precision: 2 }) || '—'} | ||||||
| </span> | ||||||
| </div> | ||||||
|
|
||||||
| <div className={clsx(COLUMN_WIDTHS.TIMESTAMP, 'min-w-0')}> | ||||||
| <span | ||||||
| className={clsx('block truncate text-[var(--text-tertiary)]', ROW_TEXT_CLASS)} | ||||||
| > | ||||||
| {formatDateTime(new Date(log.createdAt))} | ||||||
| </span> | ||||||
| </div> | ||||||
| </div> | ||||||
| ) | ||||||
| })} | ||||||
| </div> | ||||||
| </div> | ||||||
| ) | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The guard
resolvedId !== selectedLogIdRef.currentprevents dispatchingTOGGLE_LOGwhen the IDs match. BecauseselectedLogIdRefretains the last-selected log id even afterhandleCloseSidebar(which only changesisSidebarOpen, not the selected id), navigating back to/logs?executionId=<X>after manually closing the panel for log X will leave the sidebar closed — the effect seesresolvedId === selectedLogIdRef.currentand silently no-ops. The guard is necessary to avoid double-opening on data refetch, but it needs an additional check: if the sidebar is currently closed it should still open.