Scope organization network API routes to the organization in the URL - #1021
Merged
Merged
Conversation
SecuredOrganizationApiRoute reads orgid and nwid independently from the URL, so confirm the network belongs to the organization before invoking the handler, and scope GET_network's own lookup by organizationId. Adds coverage for organization scoping on these routes.
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The success test fixture does not verify that the requested network ID is forwarded correctly.
Review effort: Lite
Findings: None
What changed in this PR
Scopes organization network API routes to the organization in the URL and adds access-control tests.
Changes:
- Validates network ownership for secured organization routes.
- Scopes
GET_networklookup by organization. - Adds cross-organization access tests.
| File | Description |
|---|---|
src/utils/apiRouteAuth.ts |
Enforces organization/network ownership. |
src/pages/api/v1/org/[orgid]/network/[nwid]/index.ts |
Adds organization-scoped network lookup. |
src/pages/api/__tests__/v1/org/network/org.network.id.access.test.ts |
Tests authorized and cross-organization access. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SecuredOrganizationApiRoutereadsorgidandnwidindependently from the URL. This confirms the network belongs to the organization before invoking the handler, and scopesGET_network's own lookup byorganizationId.Adds test coverage for organization scoping on these routes.