Skip to content

fix: show feedback when WebRTC connection fails - #866

Merged
imguoguo merged 1 commit into
sipeed:mainfrom
SiYue-ZO:fix/webrtc-connection-feedback
Aug 13, 2026
Merged

fix: show feedback when WebRTC connection fails#866
imguoguo merged 1 commit into
sipeed:mainfrom
SiYue-ZO:fix/webrtc-connection-feedback

Conversation

@SiYue-ZO

@SiYue-ZO SiYue-ZO commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fixes an issue where users only saw a black screen when the initial WebRTC connection failed.

Changes

  • Show a persistent notification when signaling or WebRTC connection fails
  • Automatically recreate the WebSocket and PeerConnection after failure
  • Keep the notification visible during reconnection and dismiss it once connected
  • Use a stable Ant Design notification key to prevent duplicates
  • Add translations for all supported languages

@SiYue-ZO

SiYue-ZO commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@imguoguo

@imguoguo

Copy link
Copy Markdown
Member

The toast auto-dismisses after 2 seconds — can we keep it on screen? And since we're on antd, it already has notification utilities, so let's avoid a custom implementation.

@SiYue-ZO
SiYue-ZO force-pushed the fix/webrtc-connection-feedback branch 3 times, most recently from f3c77d0 to 5fb8661 Compare August 11, 2026 07:48
@SiYue-ZO
SiYue-ZO force-pushed the fix/webrtc-connection-feedback branch from 5fb8661 to 0224253 Compare August 11, 2026 08:46
@imguoguo
imguoguo merged commit d382f06 into sipeed:main Aug 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants