fix(tools): honor exec timeout and boolean run options - #3319
Open
MrTreasure wants to merge 1 commit into
Open
Conversation
This was referenced Aug 7, 2026
|
This PR has had no activity for 7 days and has been marked as stale. If you are still working on it, please push an update or leave a comment; otherwise it will be closed automatically in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
The
exectool advertises a per-runtimeoutargument, but synchronous execution always used the configured global timeout and silently ignored the supplied value. The tool schema also declaredbackgroundandptyas strings even though they are boolean options and the executor accepts boolean values.This PR:
backgroundandptyas JSON booleans;poll/readinstead of synchronous sleeps after a timeout;This is a focused follow-up to #2161, limited to the exec option contract. It also relates to the fixed global-timeout report in #1025.
🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
📚 Technical Context (Skip for Docs)
🧪 Test Environment
Tests run:
go test ./pkg/tools -count=1go vet ./pkg/toolsmake testwas also run. It reached an unrelated existing failure inTestMCPAddRejectsNonExecutableLocalCommandbecause the NAS temporary filesystem does not preserve the test's non-executable mode; this branch does not modify MCP code.📸 Evidence (Optional)
Behavior verified
backgroundandptyparameters pass schema validation.☑️ Checklist