fix(channels): block private targets on inbound media downloads - #3322
Open
SashaMIT wants to merge 1 commit into
Open
fix(channels): block private targets on inbound media downloads#3322SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
OneBot already set BlockPrivateTargets on DownloadFile. QQ, Telegram, Discord, LINE, and Slack still used the default (unguarded) client, so a crafted attachment URL could reach loopback, link-local, or RFC1918 (including cloud metadata) via redirect. Enable the existing safe client on those inbound download paths. Signed-off-by: Sasha Mitchell <sash@ela.city>
|
|
This was referenced Aug 9, 2026
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utils.DownloadFilealready supports SSRF hardening viaBlockPrivateTargets(safe dial + redirect re-check). OneBot used it; QQ / Telegram / Discord / LINE / Slack inbound attachment downloads did not, so a crafted media URL could still reach loopback, link-local, or RFC1918 (including cloud metadata) through redirects.This PR enables
BlockPrivateTargets: trueon those channel download paths (parity with OneBot).Test plan
go test ./pkg/utils/ -count=1(existingTestDownloadFile_BlockPrivateTargetsBlocksRedirectToLoopback)Tip:
49183d7Made with Cursor