feat(cct-sdk): Add mint/burn role management ops - #402
Open
apedrob wants to merge 4 commits into
Open
Conversation
apedrob
requested review from
a team,
PabloMansanet and
aelmanaa
as code owners
September 4, 2026 15:32
|
You must have Developer access to commit code to Chainlink Labs on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
mervin-link
approved these changes
Sep 7, 2026
mervin-link
left a comment
mervin-link
left a comment
Collaborator
There was a problem hiding this comment.
Approved ✅
Tested all ops in sepolia:
- Grant mint role ✅
- Grant burn role ✅
- Grant mint and burn roles ✅
- Revoke mint role ✅
- Revoke burn role ✅
Question
- What is the plan for supporting v2.0 tokens? Since their mint/burn authorization uses
AccessControlrather thanisMinter/isBurnerplusowner(), I’m concerned we’ll need to duplicate these readers and operations per version.
Collaborator
Overview✅ APPROVE — 0 blockers, 0 correctness majors. Correct, type-safe, contract-grounded, and live-proven. Adds 5 EVM token role ops ( Contract grounding:
Family gating: Live Sepolia verification: All ops (grant/revoke/combined/no-op/owner/family) proven on real throwaway v1.5.1 token [COMMENT 1/6] 🔴 HIGH (DX/Coverage) — Version mismatch trap: ops reject the token
|
Collaborator
[COMMENT 2/6] 🟡 Coordination — Collides with sibling DAPP-11353 on
|
Collaborator
[COMMENT 3/6] 🟡 Medium (DX) — No in-SDK source for the token these ops requireSince Impact: Users reach these ops and have no in-SDK way to produce a compatible token (v2 Fix: Document where the compatible v1.5.1/v1.6.2 Example note: |
Collaborator
[COMMENT 4/6] 🔵 Low (Arch) — Public API surface widened via
|
Collaborator
[COMMENT 5/6] 🔵 Low (Test) — Cover the two op-specific branchesThe role tests cover basic encode/submit/non-owner paths but don't explicitly cover:
Both paths are now live-proven and important for correctness. Add unit test cases for each to the test file so the no-op guards and type validation are explicitly covered in CI. Examples (pseudocode): // No-op guard: grant again
it('rejects grant when recipient already holds the role', async () => {
await grantMintRole({ token, account: A }).execute()
await expect(
grantMintRole({ token, account: A }).execute()
).rejects.toThrow(CCTParamsInvalidError)
})
// Family gate: v2 token
it('rejects v2 CrossChainToken (AccessControl, not onlyOwner)', async () => {
const v2Token = await deployToken() // returns v2.0.0 CrossChainToken
await expect(
grantMintRole({ token: v2Token, account: A }).execute()
).rejects.toThrow(CCTContractTypeInvalidError)
}) |
Collaborator
[COMMENT 6/6] 🔵 Nits
Example: /**
* Grants the BURNER_ROLE to an account on a BurnMintERC677 token.
*
* To grant both MINTER_ROLE and BURNER_ROLE in one transaction, use {@link grantMintAndBurnRoles}.
*
* @remarks
* The token must be a BurnMintERC677 (FactoryBurnMintERC20 v1.5.1 or v1.6.2).
* The Solana equivalent is `setTokenAuthority` on SPL tokens.
*
* @see {@link deployTokenPool} — primary use case
*/ |
CI Test Report✅ 2521/2527 tests passed (651 suites) in 5m 30s SummaryCoverage report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
generateUnsigned<Op>and<op>, plus theisMinter/isBurnerandownerreads they gate onWhy
Testing