Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testRunningModes #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
testRunningModes #633
Changes from 1 commit
19fa8e2aa10845d98dad05e0105fa8e087fFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure on line 19 in packages/web-components/lib/components/selfie/src/smartselfie-capture/hooks/useFaceCapture.ts
Check failure on line 21 in packages/web-components/lib/components/selfie/src/smartselfie-capture/hooks/useFaceCapture.ts
Check failure on line 155 in packages/web-components/lib/components/selfie/src/smartselfie-capture/hooks/useFaceCapture.ts
Check failure on line 156 in packages/web-components/lib/components/selfie/src/smartselfie-capture/hooks/useFaceCapture.ts
Check failure on line 160 in packages/web-components/lib/components/selfie/src/smartselfie-capture/hooks/useFaceCapture.ts
Check failure on line 161 in packages/web-components/lib/components/selfie/src/smartselfie-capture/hooks/useFaceCapture.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
setRunningModeis async but has no error handling. IfinitializeFaceLandmarker()throws (e.g. when selecting LIVE_STREAM), the subsequentsetupCanvas()andstartDetectionLoop()will still execute with a nullfaceLandmarkerRef, likely causing a runtime crash in the detection loop. [possible issue, importance: 7]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: When
runningModeisLIVE_STREAM, callingdetectForVideoon a landmarker configured withLIVE_STREAMwill throw because MediaPipe expects a callback-based API for that mode. There's no guard or try/catch around this dispatch, so the detection loop will crash and stop entirely without surfacing the error to the user. [possible issue, importance: 7]Uh oh!
There was an error while loading. Please reload this page.