Bundle STS model in credential provider#1283
Merged
Merged
Conversation
This updates the sts credential provider to bundle the model at build time. This will help prevent it from clashing with a dependency in a customer's application. Since it's still pulling from the published source, we don't have to commit the whole model and updating is trivial.
sugmanue
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
This updates the sts credential provider to bundle the model at build time. This will help prevent it from clashing with a dependency in a customer's application. Since it's still pulling from the published source, we don't have to commit the whole model and updating is trivial.
I really didn't want to just commit the model to the repo, or put it anywhere it was going to be discovered automatically by Smithy's model discovery because I don't want it leaking into places it shouldn't.
Why is this change needed?
It prevents clashing with a customer's dependency on the same model, and lets us import into environments without having to also separately import the model.
How was this validated?
Tests run and still pass.
What should reviewers focus on?
I'm importing the specific model file by name. In theory it could change, but it hasn't in 15 years so we're probably good. And if it does it probably signals something we need to be aware of anyway.
Additional Links
The cli does something similar, though more broadly to for smithy aws traits.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.