codegen: generate enum schemas for enums - #5453
Merged
adamw merged 2 commits intoAug 7, 2026
Merged
Conversation
hughsimpson
marked this pull request as ready for review
August 7, 2026 10:18
hughsimpson
changed the title
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using
derivedfor pretty much all schemas (with some exceptions for ADT types). This is wrong for enums, which needderivedEnumeration.defaultStringBasedinstead. For most codegen usecases this is probably pretty irrelevant; but if, like me, you're trying to reuse some generated schemas in websocket apis, and generating AsyncApi from that, it ends up generating some bad schemas for enums, which is sad.Updates plugin tests to reflect updated schema gen, and adds new tests that enums roundtrip through tapir and are emitting appropriately in regenerated docs for both scala 2 and scala 3. Sadly a couple of tests now no longer work for scala 2 because the runtime compiler doesn't like the enum macro; but scala 3 tests still work and this is all covered by the sbt plugin tests so no great loss.